feat: support mixed output#150
Merged
shimoncohen merged 14 commits intomasterfrom May 28, 2024
Merged
Conversation
shimoncohen
requested review from
CL-SHLOMIKONCHA,
RonitKissis,
asafMasa,
nitzanmorr and
razbroc
Contributor
ronenkapelian
left a comment
ronenkapelian
left a comment
There was a problem hiding this comment.
Looks good, amazing feature and ability!
asafMasa
requested changes
May 2, 2024
Contributor
asafMasa
left a comment
asafMasa
left a comment
There was a problem hiding this comment.
Please mind my change requests
asafMasa
reviewed
May 9, 2024
asafMasa
requested changes
May 9, 2024
asafMasa
approved these changes
May 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for mixed formats output strategy.
Meaning that you can choose the output format strategy (currently fixed / mixed).
Default is fixed, which results in all tiles are converted to supplied format. Mixed means that the tiles are stored as jpeg / png based on their content (sort of a best-effort).